Skip to content

fix(typegen): don't generate relationships across schemas #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix(typegen): don't generate relationships across schemas #809

merged 1 commit into from
Oct 9, 2024

Conversation

soedirgo
Copy link
Member

@soedirgo soedirgo commented Oct 9, 2024

PostgREST doesn't detect relationships across schemas

@soedirgo
fix(typegen): don't generate relationships across schemas
05a4760 
PostgREST doesn't detect relationships across schemas
@soedirgo soedirgo requested review from a team as code owners October 9, 2024 19:36
@soedirgo soedirgo mentioned this pull request Oct 9, 2024
Merged
avallete
avallete approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@avallete avallete left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe we'll want this not only in typescript tough. So maybe some filter at relation fetching level 🤔

Also, I wonder if that make sense for postgres-meta to not handle cross-schemas relations. PostgREST might not handle it, but postgres itself does.

@soedirgo
Copy link
Member Author

soedirgo commented Oct 9, 2024

maybe we'll want this not only in typescript tough. So maybe some filter at relation fetching level

IIRC these are used by the dashboard to detect fkeys across schemas, so we need to keep it as is.

I wonder if that make sense for postgres-meta to not handle cross-schemas relations. PostgREST might not handle it, but postgres itself does.

The typegen is designed with PostgREST use case in mind, although it's not documented as such - we may want to make this explicit at some point though (e.g. rename the route to postgrest-types/typescript)

@soedirgo soedirgo merged commit 2e54f31 into master Oct 9, 2024
4 checks passed
@soedirgo soedirgo deleted the fix/typegen-relationships-across-schemas branch October 9, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avallete avallete avallete approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soedirgo @avallete